[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e6c2b9954b: [clangd] Inactive regions support as an extension to semantic highlighting (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D67536?vs=230195=230565#toc Repository:

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 230195. nridge marked 4 inline comments as done. nridge added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files:

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + auto = DiffedLines.back(); + for (auto Iter = AddedLine.Tokens.begin(); + Iter != AddedLine.Tokens.end();) { hokein wrote: > nridge wrote: > >

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

hokein added a comment. thanks, mostly good, a few more nits. Comment at: clang-tools-extra/clangd/ParsedAST.h:134 + // Ranges skipped during preprocessing. + std::vector SkippedRanges; }; nit: it is not used anymore, remove it. Comment

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 229707. nridge added a comment. Support preamble as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/CollectMacros.h

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:100 + const std::vector () const { +return SkippedRanges; hokein wrote: > hokein wrote: > > Instead of adding new member and methods in

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

hokein added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:100 + const std::vector () const { +return SkippedRanges; hokein wrote: > Instead of adding new member and methods in `ParsedAST`, I think we can do it > in

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 228959. nridge added a comment. Add unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:143 +for (const SourceRange : + AST.getPreprocessor().getPreprocessingRecord()->getSkippedRanges()) { + if (isInsideMainFile(R.getBegin(), SM)) { hokein

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 228960. nridge marked 11 inline comments as done. nridge added a comment. Address one minor remaining comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: