[PATCH] D67740: [Consumed] Refactor and improve diagnostics

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaDeclAttr.cpp:1249 + Diag(A->getLoc(), diag::warn_consumable_attr_for_unconsumable_type) << +A << (isa(D) ? 0 : 1) << Type; + return

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex added a comment. Ping... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex updated this revision to Diff 220918. comex marked 2 inline comments as done. comex edited the summary of this revision. comex added a comment. Addressed feedback. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex marked 4 inline comments as done. comex added a comment. In D67740#1675564 , @dblaikie wrote: > Looks like this might benefit from being split into independent changes - the > work related to templates (I haven't looked closely, but I assume that's

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

dblaikie added a comment. Looks like this might benefit from being split into independent changes - the work related to templates (I haven't looked closely, but I assume that's fairly indivisible) and the work related to other diagnostics seems fairly separable - and maybe there's other pieces

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex updated this revision to Diff 220784. comex added a comment. Fixed a mistake where the diagnostic would print the wrong parameter type. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740 Files:

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex created this revision. comex added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by FIXME comments, fix commented-out diagnostic in Sema and remove the equivalent check within the consumed analysis. The diagnostic in question is