[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2020-08-07 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. cc: @t.p.northover does this fix look reasonable for PR37240? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list cfe-commits

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2020-07-03 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. In D68076#2131108 , @hiraditya wrote: > do we have a plan to follow up on this patch? Hi! I'm currently not working on this (and LLVM in general) anymore. However, the issue seems to be still present and this patch would fix

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2020-07-03 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. Herald added a subscriber: danielkiss. do we have a plan to follow up on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-10-10 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. This patch would fix PR37240 but is probably not the most optimal solution. For other ideas see http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html . I'll leave this patch open unt

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-29 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. Can we add a test to verify cfi instructions are present without debug flag. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-26 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. This would fix PR37240 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list c

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-26 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach added a comment. Please also see the ongoing discussion on the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

2019-09-26 Thread David Tellenbach via Phabricator via cfe-commits
tellenbach created this revision. Herald added subscribers: cfe-commits, kristof.beyls, aprantl. Herald added a project: clang. Currently the following situation can occur: During AArch64 frame lowering cfi instructions get emitted if debug information is generated but not if not. Since cfi inst