This revision was automatically updated to reflect the committed changes.
Closed by commit rL373104: [clangd] Fix template type aliases in
findExplicitReference (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ilya-biryukov updated this revision to Diff 04.
ilya-biryukov added a comment.
- Add a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68124/new/
https://reviews.llvm.org/D68124
Files:
clang-tools-extra/clangd/FindTarget.cpp
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:478
+ explicitReferenceTargets(DynTypedNode::create(L.getType()),
+
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:478
+ explicitReferenceTargets(DynTypedNode::create(L.getType()),
+ DeclRelation::Alias)};
}
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:478
+ explicitReferenceTargets(DynTypedNode::create(L.getType()),
+ DeclRelation::Alias)};
}
can you explain why these two are
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D68124
Files:
clang-tools-extra/clangd/FindTarget.cpp
