[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

This revision was automatically updated to reflect the committed changes. Closed by commit rL373340: [clang] Make handling of unnamed template params similar to function params (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Many thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet updated this revision to Diff 222581. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143 Files: clang/lib/AST/DeclTemplate.cpp

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc());

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc());

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc());

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet updated this revision to Diff 222567. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68143/new/ https://reviews.llvm.org/D68143 Files:

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

ilya-biryukov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:513 getDefaultArgumentInfo()->getTypeLoc().getEndLoc()); - else -return TypeDecl::getSourceRange(); + else if(getName().empty()) +return SourceRange(getBeginLoc());

[PATCH] D68143: [clang] Make handling of unnamed template params similar to function params

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Clang uses the location identifier should be inserted for declarator decls when a decl is unnamed. But for type template and template template