[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-20 Thread Djordje Todorovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce1f95a6e077: Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag" (authored by djtodoro). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Git

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-19 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-19 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. @vsk I have created the bug (llvm.org/pr44059), do you think this is OK? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-19 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro updated this revision to Diff 230054. djtodoro added a comment. -Update the lldb test for the entry values feature CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInf

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-16 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. I will do that way. Yes, only the entry values test fails, so we should skip only that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-16 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. I’d expect only the entry values test to fail. Is that the one? Could you just mark it as skipped (there are examples of how to do this for inline tests, see the skipIf decorator) and file a bugzilla PR for me to look at? CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-15 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro updated this revision to Diff 229495. djtodoro added a comment. -Add the workaround in the LLDB test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/te

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-15 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro reopened this revision. djtodoro added a comment. This revision is now accepted and ready to land. After landing this, I see one LLDB test depends on this. I made a workaround to avoid testing it at the moment. I will remove the workaround when landing the D68209

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

2019-11-15 Thread Djordje Todorovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1643734741d2: [clang] Remove the DIFlagArgumentNotModified debug info flag (authored by djtodoro). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor