This revision was automatically updated to reflect the committed changes.
Closed by commit rL373751: [clang-format] C++11 braced lists should respect the
SpacesInParentheses setting (authored by paulhoad, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
MyDeveloperDay added a comment.
LGTM and passes
[--] Global test environment tear-down
[==] 700 tests from 21 test cases ran. (67039 ms total)
[ PASSED ] 700 tests.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68415/new/
mitchell-stellar updated this revision to Diff 223212.
mitchell-stellar added a comment.
Fixed empty parentheses unit test for C++11 braced initializer list.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68415/new/
https://reviews.llvm.org/D68415
Files:
mitchell-stellar added a comment.
You are correct. I'll work on this.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68415/new/
https://reviews.llvm.org/D68415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MyDeveloperDay added a comment.
@mitchell-stellar I pulled the patch to commit it, but the unit tests fail,
could you double-check them for me?
[ OK ] FormatTest.LayoutBraceInitializersInReturnStatement (13 ms)
[ RUN ] FormatTest.LayoutCxx11BraceInitializers
mitchell-stellar added a comment.
Thanks. Please commit on my behalf when you have a chance.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68415/new/
https://reviews.llvm.org/D68415
___
cfe-commits mailing list
MyDeveloperDay added a comment.
understood, ok LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68415/new/
https://reviews.llvm.org/D68415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mitchell-stellar added a comment.
If you want spaces in your C++11 initializers and nothing else, then you don't
want the `Cpp11BracedListStyle` setting enabled. Turning it off gives you
spaces inside without affecting anything else.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
MyDeveloperDay added a comment.
what if you have this
vector{1, 2, 3};
new int[3]{1, 2, 3};
foo(int f);
but want this:
vector{ 1, 2, 3 };
new int[3]{ 1, 2, 3 };
foo(int f);
wouldn't turning on `SpacesInParentheses: true` now mean you get
vector{ 1, 2, 3 };
new int[3]{ 1, 2,
mitchell-stellar updated this revision to Diff 223077.
mitchell-stellar added a comment.
Added additional unit tests to verify that the `SpaceInEmptyParentheses`
setting is also correctly adhered to.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68415/new/
mitchell-stellar added a comment.
I don't think that's a good idea, considering the fact that braces can mean
different things in different contexts, and it would cause trouble for existing
clang-format settings.
If a hypothetical `SpacesInBraces` were `false` by default, then you could have
MyDeveloperDay added a comment.
Should we have `SpacesInBraces`? as a first class formatting option, given
that we have?
SpaceBetweenBraces.SpacesInAngles = true;
SpaceBetweenBraces.SpacesInParentheses = true;
SpaceBetweenBraces.SpacesInSquareBrackets = true;
Repository:
rC Clang
mitchell-stellar created this revision.
mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan.
mitchell-stellar added a project: clang-format.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
According to the clang-format documentation, "Fundamentally, C++11 braced
13 matches
Mail list logo
