ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68746/new/
https://reviews.llvm.org/D68746
___
cfe-commits mailing list
ABataev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
sdmitriev wrote:
> grokos wrote:
> >
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
grokos added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
sdmitriev wrote:
> ABataev wrote:
> >
sdmitriev added a subscriber: grokos.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
ABataev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
sdmitriev wrote:
> ABataev wrote:
> >
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:174
+ /// Global variable that represents BinDesc is returned.
+ GlobalVariable *createBinDesc(ArrayRef> Bufs) {
+// Create external begin/end symbols for the offload
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
ABataev wrote:
> Same question as
ABataev added inline comments.
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+ IntegerType *getSizeTTy() {
+switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+case 4u:
Same question as before: maybe better