[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68746/new/ https://reviews.llvm.org/D68746 ___ cfe-commits mailing list

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > grokos wrote: > >

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-11 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u:

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-10 Thread George Rokos via Phabricator via cfe-commits
grokos added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > ABataev wrote: > >

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-10 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev added a subscriber: grokos. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u:

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > ABataev wrote: > >

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-10 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:174 + /// Global variable that represents BinDesc is returned. + GlobalVariable *createBinDesc(ArrayRef> Bufs) { +// Create external begin/end symbols for the offload

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-10 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: ABataev wrote: > Same question as

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

2019-10-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: Same question as before: maybe better