[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

This revision was automatically updated to reflect the committed changes. Closed by commit rG243ebfba17da: [hip][cuda] Fix the extended lambda name mangling issue. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D68818?vs=225678=225720#toc Repository: rG LLVM Github

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclCXX.h:1713 + /// mangling number. + bool hasKnownInternalLinkage() const { +assert(isLambda() && "Not a lambda closure

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao updated this revision to Diff 225678. hliao added a comment. minor test case revising. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao updated this revision to Diff 225452. hliao added a comment. Force numbering on all lambdas in CUDA/HIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rjmccall added a comment. I agree with Richard's suggestion of just numbering all the lambdas in both modes if that's viable. Comment at: clang/include/clang/AST/DeclCXX.h:587-590 +unsigned NumExplicitCaptures : 12; + +/// Has known `internal` linkage. +unsigned

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao marked an inline comment as done. hliao added a comment. In D68818#1711698 , @rsmith wrote: > Broadly, I think it's reasonable to number additional lambda expressions in > CUDA compilations. However: > > - This is (in theory) an ABI break on the

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rsmith added a comment. Broadly, I think it's reasonable to number additional lambda expressions in CUDA compilations. However: - This is (in theory) an ABI break on the host side, as it changes the lambda numbering in inline functions and function templates and the like. That could be

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. In D68818#1709688 , @tra wrote: > @rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules > & ABI scare me. :-) @tra thanks for promoting the review. This patch is quite critical to support extended lambda

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

tra added a comment. @rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules & ABI scare me. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao marked 2 inline comments as done. hliao added a comment. minor comment to help review. BTW, as the AST ser/deser is changed as well, not sure we have compatibility issue and, if there is, how to handle that. please advice me on that concern. Thanks. Comment at:

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. this's a patch address the same issue previously proposed to be worked around in https://reviews.llvm.org/D63164 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao created this revision. hliao added reviewers: tra, rsmith, yaxunl. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. - HIP/CUDA host side needs to use device kernel symbol name to match the device side