Charusso closed this revision.
Charusso added a comment.
Forgotten `amend` of commit message. Commited as:
https://github.com/llvm/llvm-project/commit/8d288a0668a574863d52784084ff565c89f7366e
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from the release notes alias request.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
Eugene.Zelenko added a comment.
Will be good idea to mention alias in Release Notes too (in aliases section, in
alphabetical order).
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
abelkocsis updated this revision to Diff 226746.
abelkocsis added a comment.
Alias added to //cert// module
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
Files:
Eugene.Zelenko added a comment.
You should also add actual alias code to //cert// module.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
___
cfe-commits
abelkocsis updated this revision to Diff 226648.
abelkocsis added a comment.
Small fix in documentation
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
Files:
abelkocsis updated this revision to Diff 226598.
abelkocsis marked an inline comment as done.
abelkocsis added a comment.
Small fixes
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
Files:
abelkocsis updated this revision to Diff 226596.
abelkocsis marked 4 inline comments as done.
abelkocsis added a comment.
Checker moved to bugprone module, cert alias added. Small fixes in checker
file, warning message updated.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
abelkocsis marked 3 inline comments as done.
abelkocsis added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/misc-bad-signal-to-kill-thread.rst:8
+``SIGTERM`` signal and the signal kills the entire process, not just the
+individual thread. Use any signal
steakhal added inline comments.
Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:28
+
+static Preprocessor *PP;
+
Can't we place this `PP` variable to the checker class?
Like the [[
aaron.ballman added a comment.
Thank you for this! I don't think that the check should live in `misc`. It
should have an alias in the `CERT` module, but maybe we want to have this live
in a `posix` module? If not, this should probably live in `bugprone`.
Comment at:
abelkocsis updated this revision to Diff 225834.
abelkocsis added a comment.
Findig SIGTERM replaced on checker
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
Files:
abelkocsis updated this revision to Diff 225788.
abelkocsis added a comment.
The documentation of the checker updated.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
Files:
abelkocsis updated this revision to Diff 225786.
abelkocsis added a comment.
Test clang-formatted. Uncaught word removed from documentations.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
Files:
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/misc-bad-signal-to-kill-thread.rst:9
+individual thread. Use any signal except ``SIGTERM`` or ``SIGKILL``.
+To learn more about this rule please visit the following page:
abelkocsis updated this revision to Diff 225784.
abelkocsis marked an inline comment as done.
abelkocsis added a comment.
Header documentation and Release Notes synchronised. Documentation of
checker updated. Type changed to auto type when necessary.
Repository:
rCTE Clang Tools Extra
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:31
+void BadSignalToKillThreadCheck::check(const MatchFinder::MatchResult )
{
+ Preprocessor::macro_iterator It = PP->macro_begin();
+ while (It !=
abelkocsis updated this revision to Diff 225769.
abelkocsis added a comment.
Auto types replaced on checker files. New lines added when necessary.
Reordered ReleaseNotes by alphabetical order. Checker name is
updated on ReleaseNotes, compliant solution is wrote to the
documentation. Another
abelkocsis added a comment.
Thank you for the reviews!
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69181/new/
https://reviews.llvm.org/D69181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steakhal added inline comments.
Comment at:
clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:34-48
+ Preprocessor::macro_iterator It = PP->macro_begin();
+ while (It != PP->macro_end() && !SigtermValue.hasValue()) {
+if (It->first->getName() == "SIGTERM")
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:28
+
+namespace {
+static Preprocessor *PP;
static is enough, no need for anonymous namespace.
Comment at:
abelkocsis created this revision.
abelkocsis added reviewers: aaron.ballman, alexfh, JonasToth, steakhal,
Charusso.
abelkocsis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, mgehre, jfb, dexonsmith, steven_wu,
hiraditya, xazax.hun, mgorny, mehdi_amini.
Herald added a
22 matches
Mail list logo
