[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-25 Thread Victor Campos via Phabricator via cfe-commits
vhscampos updated this revision to Diff 226430. vhscampos added a comment. Add support for __clsll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69250/new/ https://reviews.llvm.org/D69250 Files: clang/include/clang/Basic/BuiltinsAArch64.def c

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-23 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); vhscampos wrote: > compnerd wrote: > > vhscampos wrote: > > > compnerd wrote: > > > > I don't see

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-23 Thread Victor Campos via Phabricator via cfe-commits
vhscampos marked 2 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd wrote: > vhscampos wrote: > > compnerd wrot

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-22 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); vhscampos wrote: > compnerd wrote: > > I don't see a pattern match for the `cls64` on ARM32, woul

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-22 Thread Victor Campos via Phabricator via cfe-commits
vhscampos marked 4 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd wrote: > I don't see a pattern match for th

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-21 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); I don't see a pattern match for the `cls64` on ARM32, would that not fail to lower? ==

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

2019-10-21 Thread Victor Campos via Phabricator via cfe-commits
vhscampos created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Writing support for two ACLE functions: unsigned int __cls(uint32_t x) unsigned int __clsl(unsigned long x) CLS stands for "Count number of lead