[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff abandoned this revision. sepavloff added a comment. Implemented in D87528 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69272/new/ https://reviews.llvm.org/D69272 ___

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. In D69272#2271338 , @sepavloff wrote: > In D69272#2268337 , @mibintc wrote: > >> I am working on a task to ensure that clang is doing floating point constant >> folding correctly. > > Could

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff added a comment. In D69272#2268337 , @mibintc wrote: > I am working on a task to ensure that clang is doing floating point constant > folding correctly. Could you please share your plans on it? I recently also started implementing constant fol

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

kpn added a comment. Say, in D80952 I added support for disabling strictfp support when a target doesn't support it. But it only applies to command line arguments. Is there any chance at all that relevant pragmas can also be disabled with the warning in the sa

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. Hello, I rebased this and made a few changes here, https://reviews.llvm.org/D87528 ; I added a question about floating point constant folding in that review, I'm going to duplicate it here, My question is about constant folding. I am working on a task to ensure that cl

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

rjmccall added a comment. In D69272#1865266 , @rsmith wrote: > I don't see any changes to the constant evaluator here. You need to properly > handle constant evaluation within `FENV_ACCESS ON` contexts, somehow, or > you'll miscompile floating-point oper

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I don't see any changes to the constant evaluator here. You need to properly handle constant evaluation within `FENV_ACCESS ON` contexts, somehow, or you'll miscompile floating-point

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:386 + if (FPFeatures.allowFEnvAccess()) { +FunctionDecl *F = getCurFunctionDecl(); +F->setUsesFPIntrin(true); There isn't necessarily a current function declaration; this is usable i

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff updated this revision to Diff 241352. sepavloff added a comment. Avoid using custom attribute, use Function::useFPIntrin instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69272/new/ https://reviews.llvm.org/D69272 Files: clang/inc

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff updated this revision to Diff 235392. sepavloff added a comment. Updated patch Removed the previous limitation on use of the pragma, which restricted the pragma to the topmost block only. It should favor users who do not bother about performance but want the usage be as defined by the S