lenary updated this revision to Diff 229542.
lenary added a comment.
Rebase and update comments and release notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
Files:
clang/docs/ReleaseNotes.rst
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe3d5ff5a0b10: [RISCV] Match GCC `-march`/`-mabi` driver
defaults (authored by lenary).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
asb accepted this revision.
asb added a comment.
Please update the commit message to clarify the cases where we do deviate from
the GCC defaults, but this looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
lenary updated this revision to Diff 228728.
lenary added a comment.
- Rebase
- Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
Files:
clang/docs/ReleaseNotes.rst
lenary added a comment.
I think this is just about ready to land, given our discussion on the RISC-V
call on 7 November 2019.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
khchen added a comment.
LGTM, thanks for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lenary updated this revision to Diff 227418.
lenary added a comment.
- Update tests to reflect new defaults
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
Files:
clang/docs/ReleaseNotes.rst
lenary updated this revision to Diff 227284.
lenary added a comment.
- More conservative march/mabi defaults on riscv-unknown-elf
- Add clang release notes about this change to -march/-mabi
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
lenary marked an inline comment as done.
lenary added a comment.
I agree backwards compatibility is hard here.
- This method was introduced to have a single place to choose a default `march`
string if none was chosen before. I think this change is useful (saves defaults
being calculated in a
simoncook added a comment.
I have a question about backwards compatibility with this patch. Clang 9 has
shipped with rvXXg/etc defaulting to ilp32/lp64 ABI, and no march meaning
rvXXi, with users having built objects with those defaults. When Clang 10
ships, users they now need to always use a
rogfer01 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475
+
+if (MArch.startswith_lower("rv32")) {
+ if (MArch.substr(4).contains_lower("d") ||
lenary wrote:
> rogfer01 wrote:
> > `llvm::StringSwitch` has a method
lenary marked an inline comment as done.
lenary added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537
+ if (Triple.getArch() == llvm::Triple::riscv32)
+return "rv32gc";
else
khchen wrote:
> Why do you set rv32gc and rv64gc as
khchen added inline comments.
Herald added a subscriber: sameer.abuasal.
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537
+ if (Triple.getArch() == llvm::Triple::riscv32)
+return "rv32gc";
else
Why do you set rv32gc and rv64gc as default march?
lenary marked an inline comment as done.
lenary added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475
+
+if (MArch.startswith_lower("rv32")) {
+ if (MArch.substr(4).contains_lower("d") ||
rogfer01 wrote:
>
rogfer01 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475
+
+if (MArch.startswith_lower("rv32")) {
+ if (MArch.substr(4).contains_lower("d") ||
`llvm::StringSwitch` has a method `StartsWithLower` which might help make
lenary updated this revision to Diff 226252.
lenary added a comment.
- Correct code formatting issue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69383/new/
https://reviews.llvm.org/D69383
Files:
clang/lib/Driver/ToolChains/Arch/RISCV.cpp
lenary created this revision.
lenary added reviewers: asb, luismarques, rogfer01, kito-cheng, khchen.
Herald added subscribers: cfe-commits, pzheng, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,
MaskRay, jrtc27, shiva0217, niosHD,
18 matches
Mail list logo
