[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

doug.gregor added a comment. In D69420#1757664 , @Bigcheese wrote: > It was already there from a previous commit. I see it in tree currently. Oh, sorry. I missed it in my cherry-picking and GitHub search failed to find it. Repository: rG LLVM Github

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese added a comment. It was already there from a previous commit. I see it in tree currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 ___ cfe-comm

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

doug.gregor added a comment. It looks like Inputs/modules_cdb.json missing from this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 ___ cfe-commits mail

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

arphaman accepted this revision. arphaman added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:43 + +class ModuleDepCollectorPP final : public PPCallbacks { +public: --

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese updated this revision to Diff 226974. Bigcheese added a comment. I forgot to clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 Files: clang/include/clang/Tooling/DependencyScanning/D

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese updated this revision to Diff 226972. Bigcheese set the repository for this revision to rG LLVM Github Monorepo. Bigcheese added a comment. This fixes some issues I received externally. - Fix issue with MSVC getting confused about `ModuleDeps::ModuleDeps`. - Always generate absolute pat

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:94 + +void printDependencies(std::string &S, StringRef MainFile) { + // Sort the modules by name to get a deterministic order. kousikk wrote: > S

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese updated this revision to Diff 226508. Bigcheese marked 3 inline comments as done. Bigcheese added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 Files: clang/include/clang/Tooling/DependencyScanni

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

kousikk added a comment. A few nit comments Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:34 +/// The format that is output by the dependency scanner. +enum class ScanningFormat { + /// This is the Makefile compatible dep format. -

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese created this revision. Bigcheese added reviewers: arphaman, kousikk. Bigcheese added a project: clang. Herald added subscribers: tschuett, dexonsmith, mgrang, mgorny. This adds experimental support for extracting a Clang module dependency graph from a compilation database. The output for