[PATCH] D69493: Add -fconvergent-functions flag

[Matt Arsenault via Phabricator via cfe-commits]

arsenm closed this revision.
arsenm added a comment.

e531750c6cf9ab6ca987ffbfe100b1d766269eb5 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69493/new/

https://reviews.llvm.org/D69493



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69493: Add -fconvergent-functions flag

[Artem Belevich via Phabricator via cfe-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM.

> The CUDA builtin library is apparently compiled in C++ mode, so the
>  assumption of convergent needs to be made in a typically non-SPMD
>  language.

I think the key here is that we sometimes may need to compile things for device 
**without** `-x cuda` and that changes the default assumption about 
convergence. This flag allows controlling the assumption explicitly without 
relying on input language.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69493/new/

https://reviews.llvm.org/D69493



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69493: Add -fconvergent-functions flag

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D69493#1722894 , @jlebar wrote:

> I'm confused about "The CUDA builtin library is apparently compiled in C++ 
> mode".  By...whom, and for what purposes?
>
> No objections from me, this seems reasonable regardless, but I'd also like 
> tra to weigh in, since it's been a while for me.


That's what the comment says in propagate-metadata.cu:

> // Build the bitcode library.  This is not built in CUDA mode, otherwise it
>  // might have incompatible attributes.  This mirrors how libdevice is built.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69493/new/

https://reviews.llvm.org/D69493



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits