[PATCH] D69564: Include the mangled name in -ast-dump=json

arphaman added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. @arphaman Should be fixed by rG09c7e51283dafbfd122cc0d7ab251476c451c9f5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llv

[PATCH] D69564: Include the mangled name in -ast-dump=json

arphaman added a comment. @arichardson The modified test is failing on Darwin. Here's the log output: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/5694/consoleFull Can you please address the test failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69564: Include the mangled name in -ast-dump=json

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c3048c18b09: Include the mangled name in -ast-dump=json (authored by Alex Richardson ). Changed prior to commit: https://reviews.llvm.org/D69564?vs=226893&id=229514#t

[PATCH] D69564: Include the mangled name in -ast-dump=json

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. I've split out the update script changes into D70119 to make this easier to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 _

[PATCH] D69564: Include the mangled name in -ast-dump=json

aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Thank you for your patience with my delayed review, I've been at standards meetings for C and C++ and I'm a bit behind schedule. > The AST dump tests were updated using the following script: One of the things @rsmith and I

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. Ping. Does this seem an acceptable change to the JSON output @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 ___ c

[PATCH] D69564: Include the mangled name in -ast-dump=json

MaskRay added a comment. > I am planning to use this feature to make update_cc_checks.py less fragile by > obtaining the mangled names directly from -ast-dump=json. `update_cc_checks.py` -> `update_cc_test_checks.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re