[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6c492d7a98: [RISCV] Fix ILP32D lowering for double+double/double+int return types (authored by jrtc27). Changed prior to commit: https://reviews.llvm.org/D69590?vs=226981=237912#toc Repository: rG

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

lenary accepted this revision. lenary added a comment. @jrtc27 It would be good to get this in for LLVM 10.0. Having gone through the logic with @asb, we are both confident this is the right fix, and this patch does not require any additions at the moment. Repository: rG LLVM Github

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luismarques. This looks good to me, thanks James. I had a closer step through of the logic here to convince myself. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

lenary added a comment. In D69590#1728628 , @asb wrote: > Thanks James - won't this still leave problems for structs that need > flattening? The tests in clang/test/CodeGen/riscv32-ilp32d-abi.c already include lots of cases that include flattening. I

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

asb added a comment. Thanks James - won't this still leave problems for structs that need flattening? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69590/new/ https://reviews.llvm.org/D69590 ___

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

jrtc27 created this revision. jrtc27 added a reviewer: asb. Herald added subscribers: cfe-commits, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal,