This revision was automatically updated to reflect the committed changes.
Closed by commit rG021685491727: [Clang] Pragma vectorize_width() implies
vectorize(enable) (authored by SjoerdMeijer).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69628/new/
https://reviews.llvm.org/D69628
___
cfe-commits mailing list
SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306
+// Imply vectorize.enable when it is not already disabled/enabled.
+Args.push_back(
+MDNode::get(Ctx, {MDString::get(Ctx,
Meinersbur added inline comments.
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306
+// Imply vectorize.enable when it is not already disabled/enabled.
+Args.push_back(
+MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.vectorize.enable"),
+
SjoerdMeijer updated this revision to Diff 229255.
SjoerdMeijer added a comment.
Thanks again for the suggestion; this indeed (hopefully) looks a lot neater now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69628/new/
https://reviews.llvm.org/D69628
Files:
SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306
+// Imply vectorize.enable when it is not already disabled/enabled.
+Args.push_back(
+MDNode::get(Ctx, {MDString::get(Ctx,
Meinersbur added a comment.
Sorry for the delay, for some reason I did not see a notification for the
update.
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:302-306
+// Imply vectorize.enable when it is not already disabled/enabled.
+Args.push_back(
+
SjoerdMeijer updated this revision to Diff 227273.
SjoerdMeijer added a comment.
Thanks Michael!
- moved the handling of vectorize.enable to 1 place,
- that should have also sorted the relative ordering, and duplication of the
metadata in some cases,
- created a separate file for the new tests,
Meinersbur requested changes to this revision.
Meinersbur added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:272-277
+ if (Attrs.VectorizeWidth > 1 &&
+ Attrs.VectorizeEnable == LoopAttributes::Unspecified)
+
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: Meinersbur, fhahn, rupprecht.
This got reverted because given the following source:
void a() {
#pragma clang loop vectorize(disable)
for (;;)
;
}
it incorrectly enabled vectorisation and set metadata due to a
10 matches
Mail list logo