[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

leonardchan added a comment. Yup, a bisect shows it was this patch that caused it. I filed a bug for tracking at https://bugs.llvm.org/show_bug.cgi?id=43950 and attached a reproducer. Could you look into this? Thanks. Comment at: clang/lib/Sema/SemaExpr.cpp:487 +const

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

leonardchan added a comment. Hi. I have a suspicion this patch is causing a segfault for us when building zircon: https://ci.chromium.org/p/fuchsia/builders/ci/fuchsia-x64-debug-clang/b8897388724384628544 I'm almost done with a bisect and will provide a reproducer if this is the case. Just

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG01b10bc7b149: [Diagnostics] Teach -Wnull-dereference about address_space attribute (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228301. xbolva00 added a comment. Removed unused variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228303. xbolva00 added a comment. Fixed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs.c

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 228298. xbolva00 added a comment. More tests. Handle __attribute__((address_space(0))). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files:

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a testing request. Comment at: clang/lib/Sema/SemaExpr.cpp:486 if (UO->getOpcode() == UO_Deref && -

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:486 if (UO->getOpcode() == UO_Deref && -UO->getSubExpr()->IgnoreParenCasts()-> - isNullPointerConstant(S.Context,

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 227286. xbolva00 added a comment. Added testcase with typedefed int. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang should not warn for: test.c:2:12: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]