[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

MaskRay added a comment. > So this is truly a test of the ld.otherlinker feature pattern, not some > special case driver feature. I guess we should leave the test alone. > Closing, we left the test alone, it still uses -fuse-ld=lld-link2. Perhaps in > the future we should reconsider this, but

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk closed this revision. rnk added a subscriber: MaskRay. rnk added a comment. Closing, we left the test alone, it still uses `-fuse-ld=lld-link2`. Perhaps in the future we should reconsider this, but that's how things stand now, and we aren't going to land this patch as is. + @MaskRay , who

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

cor3ntin added a comment. Herald added a project: All. @rnk can we close this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 ___ cfe-commits mailing list

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk added a comment. Oh, here's the linker it has found: $ find ../clang/ -iname '*lld-link2' ../clang/test/Driver/Inputs/Windows/ARM/8.1/usr/bin/ld.lld-link2 So this is truly a test of the `ld.otherlinker` feature pattern, not some special case driver feature. I guess we should leave the

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk added a comment. I applied this locally, but the test doesn't pass. I can look into it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 ___

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. Do I need to do anything more with this, or will somebody else just merge this at come point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk accepted this revision. rnk added a comment. In D69763#1733382 , @Ericson2314 wrote: > I am curious, how did this work since there is no longer an `lld-link2`? Were > these tests failing or not being run? These tests don't actually need to run the

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. I am curious, how did this work since there is no longer an `lld-link2`? Were these tests failing or not being run? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems like a good idea since lld link2 has been made into lld link for a while now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No idea why these are still here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69763 Files: clang/test/Driver/windows-cross.c Index: