[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-07-09 Thread Luboš Luňák via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG31b05692cd33: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69778?vs=263839=276726#toc Repository: rG

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-07-08 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-07-06 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping ... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-06-30 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-06-21 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. So what more needs to be done here to get this change accepted? It's already missed 10.0 and 11.1 is getting branched off in about 3 weeks. - The change was already accepted once and the problem leading to its revert has already been fixed. - It just enables for PCH

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-26 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D69778#2035805 , @llunak wrote: > @aganea Have you tried how this version of the patch affects PR44953? If not, > could you please try? I've applied the patch, I don't see the issue raised in PR44953 anymore. However as

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-14 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a subscriber: aganea. llunak added a comment. In D69778#2035318 , @dblaikie wrote: > Do you have a sense of the larger testing that PR44953 was reduced from? Have > you tried compiling a non-trivial codebase (I assume you might've tested it

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D69778#2035006 , @llunak wrote: > In D69778#2032363 , @dblaikie wrote: > > > So the original commit ( cbc9d22e49b4 > >

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread Luboš Luňák via Phabricator via cfe-commits
llunak updated this revision to Diff 263839. llunak edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#2032363 , @dblaikie wrote: > So the original commit ( cbc9d22e49b4 > ) was > reverted at some point, and now you're proposing recommitting it with a

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-13 Thread Luboš Luňák via Phabricator via cfe-commits
llunak updated this revision to Diff 263838. llunak edited the summary of this revision. llunak added a comment. Updated commit message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 Files:

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-12 Thread David Blaikie via Phabricator via cfe-commits
dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. So the original commit ( cbc9d22e49b4 ) was reverted at some point, and now you're proposing recommitting

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-12 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping? I've reopened this one as suggested in D74846 , but apparently it's kept the accepted state, so I'm not sure if this needs another approval or what to do here. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-03 Thread Luboš Luňák via Phabricator via cfe-commits
llunak updated this revision to Diff 261722. llunak added a comment. Reopening because of https://reviews.llvm.org/D74846, updated version includes the partial revert from there. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-05-03 Thread Luboš Luňák via Phabricator via cfe-commits
llunak reopened this revision. llunak added a comment. This revision is now accepted and ready to land. Reopening because of https://reviews.llvm.org/D74846, updated version includes the partial revert from there. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D69778#1929817 , @llunak wrote: > In D69778#1929737 , @dblaikie wrote: > > > I'm not sure how that could be possible - there's no data transferred > > between the compilation of the

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-18 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#1929737 , @dblaikie wrote: > I'm not sure how that could be possible - there's no data transferred between > the compilation of the TU's object files and the PCH's object file, right? Yes, there is, in a way - the PCH

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D69778#1928417 , @llunak wrote: > In D69778#1928111 , @dblaikie wrote: > > > In D69778#1927761 , @llunak wrote: > > > > > It comes from

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-18 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#1928111 , @dblaikie wrote: > In D69778#1927761 , @llunak wrote: > > > It comes from 08c5a7b8fda1b97df9d027d1ac096f93edeb6c2f . AFAICT > > -fmodules-codegen is a superset of

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D69778#1927761 , @llunak wrote: > In D69778#1927526 , @dblaikie wrote: > > > @rnk - know anything about the history of -building-pch-with-obj and > > whether it could be

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-17 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#1927526 , @dblaikie wrote: > @rnk - know anything about the history of -building-pch-with-obj and whether > it could be replaced/merged with -fmodules-codegen? (-fmodules-codegen + > -fmodules-debuginfo, perhaps?) It

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-03-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a subscriber: rnk. dblaikie added a comment. In D69778#1779042 , @llunak wrote: > In D69778#1776472 , @dblaikie wrote: > > > I guess one aspect is that -building-pch-with-obj seems like it duplicates

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-01-14 Thread Luboš Luňák via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcbc9d22e49b4: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69778?vs=227634=238115#toc Repository: rG

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-12-11 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#1776472 , @dblaikie wrote: > I guess one aspect is that -building-pch-with-obj seems like it duplicates > the fmodules-codegen concept (both basically are a flag passed during pcm/pch > build time that says "I promise

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-12-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > In D69778#1772125 , @dblaikie wrote: > >> I was/am still wondering whether there's a way to coalesce these codepaths >> between PCH and the existing modular code generation support? > > > In what way could this be united

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-12-06 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. In D69778#1771799 , @rsmith wrote: > It's a bit weird for this to be controlled by a `-fmodules` flag, but it's > only a `-cc1` flag, so I'm OK with that; we can rename it if/when we expose > it from the driver. It's a bit

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-12-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. @rsmith - thanks for looking at this. I'd looked at it a bit and I was/am still wondering whether there's a way to coalesce these codepaths between PCH and the existing modular code generation support? But if you're good with it, that's certainly good enough for me.

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-12-05 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. It's a bit weird for this to be controlled by a `-fmodules` flag, but it's only a `-cc1` flag, so I'm OK with that; we can rename it if/when we expose it from the driver. Repository: rC

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-12-05 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2019-11-03 Thread Luboš Luňák via Phabricator via cfe-commits
llunak created this revision. llunak added a reviewer: dblaikie. llunak added a project: clang. Herald added a subscriber: cfe-commits. This patch allows to build PCH's (with -building-pch-with-obj and the extra .o file) with -fmodules-codegen -fmodules-debuginfo to allow emitting shared code