[PATCH] D69958: Improve VFS compatibility on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG1275ab1620b6: Improve VFS compatibility on Windows (authored by amccarth). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth updated this revision to Diff 229197. amccarth marked an inline comment as done. amccarth added a comment. Corrected comment about default for case sensitivity. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69958/new/ https://reviews.llvm.org/D69958 Files:

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth marked an inline comment as done. amccarth added a comment. Thanks for the review. In D69958#1744861 , @vsapsai wrote: > There is one issue with a comment, apart of that everything looks good to me. > Looked into replacing slash and backslash

[PATCH] D69958: Improve VFS compatibility on Windows

vsapsai added a comment. There is one issue with a comment, apart of that everything looks good to me. Looked into replacing slash and backslash literals with calls to `llvm::sys::path::get_separator` or `llvm::sys::path::is_separator` but in my attempts failed to improve existing patch.

[PATCH] D69958: Improve VFS compatibility on Windows

Bigcheese accepted this revision. Bigcheese added subscribers: JDevlieghere, benlangmuir. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Looking at the blame it would be best if @JDevlieghere @vsapsai or @benlangmuir could take a look also. CHANGES SINCE LAST

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth updated this revision to Diff 229144. amccarth marked an inline comment as done. amccarth added a comment. Modified comment per feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69958/new/ https://reviews.llvm.org/D69958 Files: clang/test/Index/index-module-with-vfs.m

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth marked 3 inline comments as done. amccarth added a comment. Friendly ping for any VFS experts to comment. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:657 + // slashes to match backslashes (and vice versa). + bool pathComponentMatches(llvm::StringRef

[PATCH] D69958: Improve VFS compatibility on Windows

rnk added a comment. This looks good to me. I had one suggestion, and I would also like to hear from another reviewer who has more ownership over VFS. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:657 + // slashes to match backslashes (and vice versa). + bool

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth created this revision. amccarth added reviewers: rnk, vsapsai, arphaman, Bigcheese. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: LLVM. Keys in a virtual file system can be in Posix or Windows form or even a combination of the two. Many VFS tests (and a few