[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG6515c524b0ae: [FPEnv] clang support for constrained FP builtins (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.llvm.org/D70256 ___ cfe-commits mailing list

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

kpn updated this revision to Diff 233073. kpn added a comment. Update for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.llvm.org/D70256 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/constrained-math-builtins.c

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357 + + if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic && + CGF.Builder.getIsFPConstrained()) { kpn wrote: > rjmccall wrote: > > I don't see any situation where

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

kpn marked 2 inline comments as done. kpn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357 + + if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic && + CGF.Builder.getIsFPConstrained()) { rjmccall wrote: > I don't see any situation

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

kpn added a comment. D62731 is required for testing this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.llvm.org/D70256 ___

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357 + + if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic && + CGF.Builder.getIsFPConstrained()) { I don't see any situation where `not_intrinsic` is passed in here; why all

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

kpn created this revision. kpn added reviewers: rjmccall, dblaikie. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Currently if constrained fp math is requested clang is still emitting calls to the non-constrained versions of math builtins. This patch corrects that