[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D70268?vs=233233=233455#toc Repository:

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese added a comment. Looks like the test for -full-command-line got dropped. I'll add that when I commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

merge_guards_bot added a comment. Build result: pass - 60692 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese updated this revision to Diff 233233. Bigcheese added a comment. Refactored `FullDependencies::getAdditionalCommandLine` and `ModuleDeps::getFullCommandLine` to share code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:29 + + Ret.push_back("-fno-implicit-modules"); + Ret.push_back("-fno-implicit-module-maps"); @Bigcheese It looks like there's some duplication in argument

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); arphaman wrote: > Bigcheese wrote: > >

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese updated this revision to Diff 232483. Bigcheese marked 2 inline comments as done. Bigcheese added a comment. - Removed `OutputPaths`. - Add documentation for `AlreadySeen`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); Bigcheese wrote: > arphaman wrote: > > What

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File);

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); What if `Opts.Targets` is empty?

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese marked 2 inline comments as done. Bigcheese added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:31 + /// Modules that the input directly imports. + std::vector DirectModuleDependencies; + /// The Clang modules

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:31 + /// Modules that the input directly imports. + std::vector DirectModuleDependencies; + /// The Clang modules this input transitively depends on that have

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese created this revision. Herald added subscribers: cfe-commits, tschuett, dexonsmith, mgrang. Herald added a project: clang. Bigcheese added reviewers: arphaman, kousikk. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70268 Files: