[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. 2cc11941a2e88236e0b4842229454ae6d85142cd CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm added a comment. In D70424#1758902 , @yaxunl wrote: > LGTM. But I am wondering how it affects -g. Do we need to keep frame pointer > when -g is specified? Should we add a test for -O3 -g? It’s independent for every other target. This matches the

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm added a comment. In D70424#1761298 , @arsenm wrote: > In D70424#1758902 , @yaxunl wrote: > > > LGTM. But I am wondering how it affects -g. Do we need to keep frame > > pointer when -g is specified? Should

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

scott.linder added a comment. In D70424#1759379 , @t-tye wrote: > @scott.linder can answer about the -g question, but I would expect that the > CFI is capable of describing the address of the CFA regardless of whether > there is a frame pointer by

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

t-tye added a comment. @scott.linder can answer about the -g question, but I would expect that the CFI is capable of describing the address of the CFA regardless of whether there is a frame pointer by simply knowing the constant offset from the stack pointer. For AMDGPU it seems to me what we

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

yaxunl added a comment. LGTM. But I am wondering how it affects -g. Do we need to keep frame pointer when -g is specified? Should we add a test for -O3 -g? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/ https://reviews.llvm.org/D70424

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/ https://reviews.llvm.org/D70424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm created this revision. arsenm added reviewers: yaxunl, scott.linder, t-tye. Herald added subscribers: tpr, dstuttard, wdng, kzhuravl. Enabling optimization should allow frame pointer elimination. https://reviews.llvm.org/D70424 Files: clang/lib/Driver/ToolChains/Clang.cpp