[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added a comment. In D70440#1756262 , @thakis wrote: > Do we need to add a dep on Frontend to DriverTests here? That's a heavy > dependency (it pulls in Sema etc). If it is needed, maybe the test is in the > wrong binary? We need it

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

thakis added a comment. Do we need to add a dep on Frontend to DriverTests here? That's a heavy dependency (it pulls in Sema etc). If it is needed, maybe the test is in the wrong binary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added a comment. @teemperor Sorry for the trouble. I did not run LLVM tests, so had to revert the change. Was reverted in 9f3fdb0d7fab73083e354768eb5808597474e1b8 and relanded as

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. FYI, this doesn't compile, see: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/10890 (and probably all other build bots that are starting to break). FAILED: tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

This revision was automatically updated to reflect the committed changes. Closed by commit rGba6f90685426: [Driver] Use VFS to check if sanitizer blacklists exist (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov updated this revision to Diff 230397. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove redundant semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:89 +return FS; + }; + llvm::Optional Driver; nit: semicolon Repository: rG

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov updated this revision to Diff 230394. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440 Files:

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

kadircet added inline comments. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:37 + +static constexpr const char *ClangPath = "/opt/llvm/bin/clang"; +static constexpr const char *InputFile = "/sources/foo.c"; can't this be just `clang` ? as we are

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

jkorous added inline comments. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:100 + Contains(StrEq(std::string("-fsanitize-system-blacklist=") + + ASanBlacklist))); + // User blacklists should also be added.

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added inline comments. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:71 + prepareFS(llvm::ArrayRef ExtraFiles) { + +llvm::IntrusiveRefCntPtr FS = NIT to self: remove this newline and the one before return Repository: rG LLVM

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added inline comments. Herald added a subscriber: ormris. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:100 + Contains(StrEq(std::string("-fsanitize-system-blacklist=") + + ASanBlacklist))); + // User blacklists

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: llvm-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. This is a follow-up to 590f279c456bbde632eca8ef89a85c478f15a249