[PATCH] D70535: [clangd] Define out-of-line qualify return value

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4609ec0e8cf: [clangd] Define out-of-line qualify return value (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/

[PATCH] D70535: [clangd] Define out-of-line qualify return value

merge_guards_bot added a comment. Build result: pass - 60447 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 232036. kadircet added a comment. - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D70535: [clangd] Define out-of-line qualify return value

merge_guards_bot added a comment. Build result: fail - 60408 tests passed, 1 failed and 726 were skipped. failed: Clangd Unit Tests._/ClangdTests/DefineOutlineTest.QualifyReturnValue Log files: console-log.txt

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 231866. kadircet marked 5 inline comments as done. kadircet added a comment. - Extract replacement applying part to a new function and add a fixme for sharing it with define inline code-action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70535: [clangd] Define out-of-line qualify return value

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:153 + // Get new begin and end positions for the qualified body. + auto OrigFuncRange =

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:153 + // Get new begin and end positions for the qualified body. + auto OrigFuncRange = toHalfOpenFileRange( + SM, FD->getASTContext().getLangOpts(),

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 231511. kadircet marked 9 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files:

[PATCH] D70535: [clangd] Define out-of-line qualify return value

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:69 +llvm::Optional +synthesizeContextForNS(llvm::StringRef TargetNS, + const DeclContext *CurContext) { could you add some documentations,

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 231391. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D70535: [clangd] Define out-of-line qualify return value

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "627221d6588eb650759f39e80858abb2a3848ccb". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 230841. kadircet added a comment. - Move TargetContext generation logic to a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files:

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 230439. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D69298: [clangd] Define out-of-line initial apply logic. Return type