This revision was automatically updated to reflect the committed changes.
Closed by commit rGf4bba07b87ce: [ARM][MVE][Intrinsics] Add MVE VABD
intrinsics. Add unit tests. (authored by MarkMurrayARM).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7054
MarkMurrayARM updated this revision to Diff 231055.
MarkMurrayARM added a comment.
Respond to review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70545/new/
https://reviews.llvm.org/D70545
Files:
clang/include/clang/Basic/arm_mve.td
simon_tatham added a comment.
This mostly LGTM: only a handful of nits.
Comment at: clang/include/clang/Basic/arm_mve.td:45
let params = T.Usual in {
+def vabdq: Intrinsic $a, $b)>;
+}
Can you wrap this line to 80 columns, please? I've been trying to fit the r
MarkMurrayARM updated this revision to Diff 231034.
MarkMurrayARM added a comment.
Rebase and reupload patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70545/new/
https://reviews.llvm.org/D70545
Files:
clang/include/clang/Basic/arm_mve.td
MarkMurrayARM updated this revision to Diff 230890.
MarkMurrayARM added a comment.
Merge all VABD intrinis types under T.Usual instead of doing the floats
separately.
Add more tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70545/new/
https:/
dmgreen added inline comments.
Comment at: clang/include/clang/Basic/arm_mve.td:33
let params = T.Int in {
+def vabdq: Intrinsic $a, $b)>;
def vaddq: Intrinsic;
Can this and vadbqf below be combined into one using T.Usual?
I believe the differences only usuall
MarkMurrayARM created this revision.
MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls.
Herald added projects: clang, LLVM.
Add MVE VABD intrinsics.
Repository:
rG LLVM Github Monorepo
https://reviews
