This revision was automatically updated to reflect the committed changes.
Closed by commit rGa048bf87fb65: [ARM][MVE][Intrinsics] Add MVE
VAND/VORR/VORN/VEOR/VBIC intrinsics. Add unit… (authored by MarkMurrayARM).
Changed prior to commit:
https://reviews.llvm.org/D70547?vs=231057&id=231272#toc
simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
LGTM, though I spotted a couple of even tinier last-minute nits.
Comment at: clang/include/clang/Basic/arm_mve.td:68
+// Vector and UVector may be different vecto
MarkMurrayARM updated this revision to Diff 231057.
MarkMurrayARM added a comment.
Respond to review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70547/new/
https://reviews.llvm.org/D70547
Files:
clang/include/clang/Basic/arm_mve.td
simon_tatham added inline comments.
Comment at: clang/include/clang/Basic/arm_mve.td:68
+def "": Intrinsic
+(bitcast $a, UVector),
I think it's worth adding a comment here explaining why this bitcasting isn't
overcomplicating the IR in the in
MarkMurrayARM updated this revision to Diff 231037.
MarkMurrayARM added a comment.
Rebase and reupload patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70547/new/
https://reviews.llvm.org/D70547
Files:
clang/include/clang/Basic/arm_mve.td
MarkMurrayARM updated this revision to Diff 230896.
MarkMurrayARM added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70547/new/
https://reviews.llvm.org/D70547
Files:
clang/include/clang/Basic/arm_mve.td
clang/include/clang
MarkMurrayARM updated this revision to Diff 230895.
MarkMurrayARM added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70547/new/
https://reviews.llvm.org/D70547
Files:
clang/include/clang/Basic/arm_mve.td
clang/include/clang
MarkMurrayARM updated this revision to Diff 230891.
MarkMurrayARM added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70547/new/
https://reviews.llvm.org/D70547
Files:
clang/include/clang/Basic/arm_mve.td
clang/include/clang
MarkMurrayARM created this revision.
MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls.
Herald added projects: clang, LLVM.
Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.
Repository:
rG LLVM Github Monor