[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

2019-11-25 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song abandoned this revision. yonghong-song added a comment. @dblaikie As suggested, just submitted two separate patches: - https://reviews.llvm.org/D70696 for clang/llvm change to generate debuginfo for extern variables - https://reviews.llvm.org/D70697 for BPF backend to consume such

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

2019-11-23 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @dblaikie Thanks for the review. To address your comments below: > the title talks about global variables > the description talks about extern types (guessing that's just a typo?) The title is "Support to emit debugInfo for extern variables". In the description,

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

2019-11-22 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Seems to have a few things going on - the title talks about global variables - the description talks about extern types (guessing that's just a typo?) - the patch itself seems to have code that's visiting more functions? ( processFuncPrototypes ) - & also I'd generally

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

2019-11-22 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added reviewers: aprantl, dblaikie, RKSimon, ast. yonghong-song added a project: debug-info. Herald added subscribers: llvm-commits, cfe-commits, ormris, hiraditya. Herald added projects: clang, LLVM. extern variable usage in BPF is different