[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-12-05 Thread Zurab Tsinadze via Phabricator via cfe-commits
zukatsinadze marked an inline comment as done. zukatsinadze added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:27 + hasAutomaticStorageDuration(), + unless(hasDescendant(callExpr(callee(functionDecl(hasAn

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-12-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:27 + hasAutomaticStorageDuration(), + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc", "::ma

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-11-28 Thread Zurab Tsinadze via Phabricator via cfe-commits
zukatsinadze updated this revision to Diff 231465. zukatsinadze added a comment. changes after review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70823/new/ https://reviews.llvm.org/D70823 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-extra/clang-tidy/c

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-11-28 Thread Zurab Tsinadze via Phabricator via cfe-commits
zukatsinadze marked 5 inline comments as done. zukatsinadze added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:28 + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc", "::malloc

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-11-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:28 + unless(hasDescendant(callExpr(callee(functionDecl(hasAnyName( + "::alloc", "::malloc", "::realloc", "::calloc"))) + .b

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-11-28 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:200 + + Finds calls of 'putenv' function with automatic variable as the argument. + Please use double back-ticks to highlight putenv. Repository: rCTE Clang Tools Extra

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

2019-11-28 Thread Zurab Tsinadze via Phabricator via cfe-commits
zukatsinadze created this revision. zukatsinadze added reviewers: aaron.ballman, alexfh, hokein, Charusso. zukatsinadze added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, xazax.hun, mgorny. According to https://wiki.sei.cmu.edu/confluence/display/c/POS34-C.+Do