This revision was automatically updated to reflect the committed changes.
Closed by commit rG510792a2e0e3: [ARM][MVE][Intrinsics] Add
VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics. (authored by MarkMurrayARM).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
MarkMurrayARM marked an inline comment as done.
MarkMurrayARM added a comment.
Nit terminated with extreme prejudice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70829/new/
https://reviews.llvm.org/D70829
MarkMurrayARM updated this revision to Diff 231664.
MarkMurrayARM added a comment.
Address whitespace nit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70829/new/
https://reviews.llvm.org/D70829
Files:
clang/include/clang/Basic/arm_mve.td
simon_tatham accepted this revision.
simon_tatham added a comment.
I do, but only an indentation quibble.
Comment at: clang/include/clang/Basic/arm_mve.td:205
+(select (icmp_ule $a, $b), $a, $b)>,
+
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks. I'm happy if simon does not have any extra comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70829/new/
MarkMurrayARM updated this revision to Diff 231540.
MarkMurrayARM added a comment.
Fix non-predicated floats.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70829/new/
https://reviews.llvm.org/D70829
Files:
clang/include/clang/Basic/arm_mve.td
dmgreen added inline comments.
Comment at: llvm/test/CodeGen/Thumb2/mve-intrinsics/vmaxnmq.ll:7
+; CHECK: @ %bb.0: @ %entry
+; CHECK-NEXT:vcmp.f16 ge, q0, q1
+; CHECK-NEXT:vpsel q0, q0, q1
You may want to use llvm.minnum directly (providing the
MarkMurrayARM created this revision.
Herald added subscribers: llvm-commits, cfe-commits, dmgreen, hiraditya,
kristof.beyls.
Herald added projects: clang, LLVM.
Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics and their predicated versions. Add
unit tests.
Repository:
rG LLVM Github Monorepo