[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ added a comment. In D70836#1789059 , @xazax.hun wrote: > Will this also work as intended with sugared types? (e.g. typedefs) > I believe this might be one of the main reason why the original author used > canonical types in the first place.

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

xazax.hun added a comment. Great! I have one question though. Will this also work as intended with sugared types? (e.g. typedefs) I believe this might be one of the main reason why the original author used canonical types in the first place. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d3f43ec61a6: [analysis] Discard type qualifiers when casting values retrieved from the Store. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D70836?vs=231473=234397#toc

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Hmm, it was supposed to get a green tick mark. Let me re-accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70836/new/

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ accepted this revision. NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. Thanks!! This definitely doesn't sort out all the problems of this kind, but that's a strict improvement. Do you have commit access? Or i could commit for you. Comment

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

vabridgers created this revision. vabridgers added reviewers: dcoughlin, dergachev.a. vabridgers added a project: clang. Herald added a subscriber: cfe-commits. This change fixes part 1 described by Artem in the Bugzilla report 43364. The comparison done was on a canonical, but should have been