[PATCH] D70853: [clangd] Fix a regression issue in local rename.

2019-12-02 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG902dc6c69ce7: [clangd] Fix a regression issue in local rename. (authored by hokein). Changed prior to commit:

[PATCH] D70853: [clangd] Fix a regression issue in local rename.

2019-11-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:136 + else if (!DeclaredInMainFile) +// the symbol declared outside of the main file, can't

[PATCH] D70853: [clangd] Fix a regression issue in local rename.

2019-11-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The regression is that we can't rename symbols in annonymous namespaces. Repository: rG LLVM Github Monorepo