[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864 ___ cfe-commits mailing

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-12-04 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert added a comment. As a demonstrator I put this docker image together: docker run -it --rm gitlab-registry.cern.ch/pseyfert/vim-clang-format-docker:latest open `vim Chi2PerDoF.h` and hit Ctrl+I. There is a

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-12-03 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I guess this isn't something we could test with lit right? Can you explain how this goes wrong, I've not seen it myself and I use the vim plugin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-11-29 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert updated this revision to Diff 231568. pseyfert added a comment. added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864 Files: clang/tools/clang-format/clang-format.py Index: clang/tools/clang-format/clang-format.py

[PATCH] D70864: update trailing newline treatment in clang-format.py

2019-11-29 Thread Paul Seyfert via Phabricator via cfe-commits
pseyfert created this revision. pseyfert added reviewers: klimek, MyDeveloperDay. pseyfert added projects: clang-format, clang. The current clang-format.py does not handle trailing newlines at the end of a file correctly. Trailing empty lines get removed except one. As far as I understand this