[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbab9849963eb: Reland 198fbcb8, Driver: Dont look for libc++ headers in the install… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D71154?vs=232683=232892#toc Repository: rG

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

pcc reopened this revision. pcc added a comment. This revision is now accepted and ready to land. Relanding with a fix for the problem found by @davezarzycki. The test needed to be adjusted to set `--sysroot`, otherwise it will fail in the case where a directory named `/usr/include/c++/v1` or

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

davezarzycki added a comment. Sorry, I had to revert this for breaking things. Please ping me when you have a new patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71154/new/ https://reviews.llvm.org/D71154

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

davezarzycki added a comment. Can we revert this? It doesn't seem to work on my Fedora 31 box: FAIL: Clang :: Driver/android-no-installed-libcxx.cpp (9249 of 59761) TEST 'Clang :: Driver/android-no-installed-libcxx.cpp' FAILED Script: -- :

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rG198fbcb81749: Driver: Dont look for libc++ headers in the install directory on Android. (authored by pcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

danalbert accepted this revision. danalbert added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8 +// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s +// CHECK-NOT:

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

pcc marked an inline comment as done. pcc added inline comments. Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8 +// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s +// CHECK-NOT: "-internal-isystem" "{{.*}}v1" danalbert wrote: >

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

danalbert requested changes to this revision. danalbert added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8 +// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s +// CHECK-NOT:

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

merge_guards_bot added a comment. Build result: pass - 60573 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

pcc created this revision. pcc added reviewers: danalbert, srhines. Herald added a reviewer: EricWF. Herald added a subscriber: ldionne. Herald added a project: clang. The NDK uses a separate set of libc++ headers in the sysroot. Any headers in the installation directory are not going to work on