[PATCH] D71155: [analyzer] CERT: STR30-C

2020-02-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. Thanks! I have felt that may I create a too complex symbolic value. Sorry for stealing your time. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2097-2098 +void CStringChecker::evalCharPtrCommon(CheckerContext , +

[PATCH] D71155: [analyzer] CERT: STR30-C

2020-02-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 242159. Charusso marked 8 inline comments as done. Charusso added a comment. - Remove the modeling from CStringChecker. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71155/new/ https://reviews.llvm.org/D71155 Files:

[PATCH] D71155: [analyzer] CERT: STR30-C

2020-02-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Let's separate `CStringChecker` improvements into a separate patch and have a separate set of tests for it. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2097-2098 +void CStringChecker::evalCharPtrCommon(CheckerContext , +

[PATCH] D71155: [analyzer] CERT: STR30-C

2019-12-13 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked 3 inline comments as done. Charusso added a comment. In order to bypass the `CK_LValueToRValue` `evalCast()` we have to create en `ElementRegion` as a return-value of the problematic function call. In that case for a mythical reason we miss the fact the pointer is nullable. I