[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thegameg added a comment. In D71301#1832801 , @plotfi wrote: > So, the culprit appears to be D69825 . The > way InterfaceStubs assembles the pipeline appears to trigger an asan bug. For > now I will alter the tests to get

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. So, the culprit appears to be D69825 . The way InterfaceStubs assembles the pipeline appears to trigger an asan bug. For now I will alter the tests to get the bots green, but once I get my bugzilla access sorted I intend to file a bug. -P

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. This appears to only happen with -fintegrated-cc1, with fno-integrated-cc1 it does not repro. Still looking into this. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dr

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. Thanks for pinging on this @thegameg. I had been looking at this a day or two ago but got side-tracked. Will take another look. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thegameg added a comment. Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dragon: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6886/consoleFull The following tests are failing: Clang :: InterfaceStubs/driver-test.c Clang :: InterfaceStubs/driver-test2.c

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1818233 , @thakis wrote: > This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt > > Looks like this expects itanium mangling; maybe you want `-triple > %itanium_abi_triple`? I missed this message. Sorry ab

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1818571 , @thakis wrote: > In D71301#1818233 , @thakis wrote: > > > This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt > > > > Looks like this expects itanium mangli

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. In D71301#1818233 , @thakis wrote: > This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt > > Looks like this expects itanium mangling; maybe you want `-triple > %itanium_abi_triple`? Since the bot's been red for a

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. (And thanks for the mac fix!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt Looks like this expects itanium mangling; maybe you want `-triple %itanium_abi_triple`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://re

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1817926 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS > prefixes functions with an extra `_`.) Should be fixed now. Sorry about this. Thanks Again Nico. Repository: rG

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1817926 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS > prefixes functions with an extra `_`.) Thank You Nico! Will fix Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS prefixes functions with an extra `_`.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 __

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8c8827d96f: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 237752. plotfi added a comment. Going to do an NFC pre-commit before this to add the braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 237740. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/InterfaceStubs/blocks.c clang/test/In

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 237739. plotfi added a comment. using isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/Int

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:60 + if (const auto *MD = dyn_cast_or_null(Parent)) +return true; +} Use `isa` rather than `dyn_cast_or_null`. Furthermore, the `dyn_ca

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1778834 , @compnerd wrote: > Should probably add a check for `__block` variables. I looked into it, I am not sure if anything special needs to be done for block. ie: echo "void f() { __block int x = 42; void (^sum)(i

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 233435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/InterfaceStubs/blocks.c clang/test/In

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added a comment. Should probably add a check for `__block` variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 ___ cfe-commits mailing list cfe-

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't chec