This revision was automatically updated to reflect the committed changes.
Closed by commit rGee0a3b5c776c: [MinGW] Implicitly add .exe suffix if not
provided (authored by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71400/new/
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71400/new/
https://reviews.llvm.org/D71400
___
cfe-commits mailing list
mstorsjo added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71400/new/
https://reviews.llvm.org/D71400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo updated this revision to Diff 233863.
mstorsjo marked 2 inline comments as done.
mstorsjo added a comment.
Added a code comment, using `llvm::path::has_extension`, added testcases.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71400/new/
https://reviews.llvm.org/D71400
Files:
rnk added inline comments.
Comment at: clang/lib/Driver/ToolChains/MinGW.cpp:164
+ const char *OutputFile = Output.getFilename();
+#ifdef _WIN32
+ if (!llvm::sys::path::filename(OutputFile).contains('.'))
Can you add what you wrote in the commit message as a
mstorsjo created this revision.
mstorsjo added a reviewer: rnk.
Herald added a project: clang.
GCC implicitly adds an .exe suffix if it is given an output file name, but the
file name doesn't contain a suffix, and there are certain users of GCC that
rely on this behaviour (and run into issues
