[PATCH] D71512: [clang-format] Fix short block when braking after control statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG0487f6f19cda: [clang-format] Fix short block when braking after control statement (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska added a comment. @MyDeveloperDay I don't have commit rights, could you land this change for me please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 ___ cfe-commits mailing list

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This seems to LGTM, in the absence of any other input, I guess we have to rely on the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska updated this revision to Diff 253366. Bouska added a comment. Do not touch current tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska marked an inline comment as done. Bouska added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:662 "{\n" - " ff();\n" "}", MyDeveloperDay

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska marked an inline comment as done. Bouska added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:344 - return MergedLines; -} // Don't merge block with left brace wrapped after ObjC special blocks MyDeveloperDay wrote:

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. In D71512#1815512 , @Bouska wrote: > Ping @MyDeveloperDay @klimek Comment at:

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska added a comment. Ping @MyDeveloperDay @klimek CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska updated this revision to Diff 236188. Bouska added a comment. Updated unittest to check under the column limit and over the column limit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 Files:

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska updated this revision to Diff 235435. Bouska added a comment. Set line length to column limit + 1 (41) in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:586 verifyFormat("if (true) {\n" - " ff();\n" "}", MyDeveloperDay wrote: > any reason you are

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:586 verifyFormat("if (true) {\n" - " ff();\n" "}", any reason you are changing existing

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska created this revision. Bouska added reviewers: djasper, klimek, krasimir. Bouska added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes bug #44192 When clang-format is run with option AllowShortBlocksOnASingleLine, it is