[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

dmajor added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersionArgs(Args, CmdArgs);

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek I fixed the tests in be88a20c900463c4919433109e4c17cd001da580 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. Looks like `HOST_LINK_VERSION` is influencing the decision. I should specify the version manually in the tests then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek Thanks, I think it reproduces on our macOS bots. I'll start fixing it right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

phosek added a comment. I'm not sure if the detection is working correctly, this is failing on our macOS toolchain bots: FAIL: Clang :: Driver/darwin-ld-platform-version-ios.c (5284 of 16450) TEST 'Clang :: Driver/darwin-ld-platform-version-ios.c' FAILED

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG25ce33a6e4f3: [driver][darwin] Pass -platform_version flag to the linker instead of the… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported");

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported"); arphaman wrote: > steven_wu

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersionArgs(Args, CmdArgs); Why

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous. Herald added projects: clang, LLVM. In Xcode 11, ld added a new flag called `-platform_version` that can be used instead of the old `-_version_min` flags.