[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

2020-09-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. We do now have tests in unittests/ModulesTests.cpp that likely covers at least part of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71586/new/ https://reviews.llvm.org/D71586

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

2019-12-17 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. +1, please add a unit test instead. We prefer to keep the number of lit tests in clangd minimal. They're mostly testing the LSP layer and other things which are hard to

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

2019-12-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Can we add a unit test instead of(or in addition to) this one? I suppose it should be easy to right one using `TestTU` with `ExtraArgs` and `AdditionalFiles` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71586/new/

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

2019-12-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: sammccall, jkorous. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. This patch adds a test case that verifies that `-fmodules -fimplicit-modules` work in Clangd