[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

aaron.ballman closed this revision. aaron.ballman added a comment. In D71619#1791961 , @kamleshbhalui wrote: > removed c++11 from the test. > I do not have commit access, Can someone commit this for me? Thank you for the patch! I've commit on your

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234796. kamleshbhalui added a comment. removed c++11 from the test. I do not have commit access, Can someone commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files:

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/AST/pr43983.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s -std=c++11 -ast-dump | FileCheck %s + You can drop the

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

rsmith added a comment. Seems fine to me. @aaron.ballman, want to take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234652. kamleshbhalui added a comment. added assert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files: clang/lib/Sema/SemaDecl.cpp clang/test/AST/pr43983.cpp Index:

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5037 Anon = VarDecl::Create(Context, Owner, DS.getBeginLoc(), Record->getLocation(), /*IdentifierInfo=*/nullptr, Should we apply the attributes to the

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Apply attributes on anonymous records. This Fixes https://bugs.llvm.org/show_bug.cgi?id=43983. Repository: rG LLVM Github