[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0860db966a7d: [OPENMP50]Codegen for nontemporal clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61072 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234950. ABataev added a comment. Removed check for isArrow() + added requested test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files:

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added a comment. Thanks. Could you add some tests that `nontemporal` directives aren't disturbed by either (1) nested `nontemporal` directives or (2) nested directives of some other kind? Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true); rjmccall wrote: >

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234943. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true); ABataev wrote: >

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61052 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234902. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } rjmccall wrote: > Can `E` actually be null here? No, remnants of the initial version.

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } Can `E` actually be null here? Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61027 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev created this revision. ABataev added reviewers: rjmccall, hfinkel. Herald added subscribers: arphaman, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Basic codegen for the declarations marked as nontemporal. Also, if the base declaration in the member