jyknight added a comment.
Since this change is not android-only, please update change description, and
update some non-android tests.
E.g. maybe the tests in clang/test/Driver/linux-ld.c for
ubuntu_14.04_multiarch_tree should check the path at which ld is found. While
the existing
brianpl updated this revision to Diff 237691.
brianpl added a comment.
- Search for tools prefixed with GNU target triples.
- Merge branch 'master' of https://github.com/llvm/llvm-project
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71848/new/
jyknight added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4696
+ llvm::Triple ToolchainTriple = TC.getTriple();
+ if (ToolchainTriple.isAndroid()) {
+std::string ArchName = ToolchainTriple.getArchName();
Adding the hardcoding here seems
brianpl added a comment.
> Just to clarify, this is needed for the triple-prefixed tools, but the
> triple-specific directory worked fine before this patch? If I'm understanding
> that correctly then LGTM, otherwise I'm confused as to why I haven't seen
> this problem before.
Yes, that's
danalbert accepted this revision.
danalbert added a comment.
This revision is now accepted and ready to land.
Just to clarify, this is needed for the triple-prefixed tools, but the
triple-specific directory worked fine before this patch? If I'm understanding
that correctly then LGTM, otherwise
brianpl created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
brianpl added a reviewer: jyknight.
brianpl updated this revision to Diff 235182.
brianpl added a comment.
Fix a typo.
Currently, tool discovery checks for a tool with its target triple as a
brianpl updated this revision to Diff 235182.
brianpl added a comment.
Fix a typo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71848/new/
https://reviews.llvm.org/D71848
Files:
clang/lib/Driver/Driver.cpp
