[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG048239e46e49: [Coroutines][6/6] Clang schedules new passes (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 245054. modocache removed a reviewer: wenlei. modocache removed subscribers: wenlei, hiraditya. modocache removed a project: LLVM. modocache added a comment. Rebase on top of the latest version of D71902 . Repository: rG

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 244566. modocache added a comment. Clean up coroutine intrinsics as part of the ThinLTO pre-link pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: cl

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 239437. modocache added a comment. Rebase past D72547 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/Ba

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236967. modocache added a comment. Initialize PipelineTuningOptions properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236889. modocache added a comment. Update tests -- we now re-run the SCC pass, but don't insert the coroutine funclets into the SCC, so we no longer see the funclets in the output being tested here. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236245. modocache removed a subscriber: wenlei. modocache added a comment. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Thanks for the reviews. Based on my latest revision of D71899 , the coro-split di

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added a comment. In D71903#1804016 , @modocache wrote: > I'm currently working on ensuring that CGSCC optimizations are rerun to > optimize coroutine funclets -- the primary feedback I received on this and on > D71899

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache added a comment. I'm currently working on ensuring that CGSCC optimizations are rerun to optimize coroutine funclets -- the primary feedback I received on this and on D71899 -- but I just realized I didn't respond to one comment on this set of reviews

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache planned changes to this revision. modocache marked 2 inline comments as done and an inline comment as not done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitP

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

wenlei added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1228 + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePass())); + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFun

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added a comment. There is another issue we should consider: clang is crashed when compile coroutine with -disable-llvm-passes and output an object file. Is it reasonable to run coroutine passes even -disable-llvm-passes is enabled? Comment at: clang/lib/CodeGen/Ba

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePas

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePass())); + MPM.addPass(createModuleT

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache created this revision. modocache added reviewers: GorNishanov, lewissbaker, chandlerc, junparser. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. Depends on https://reviews.llvm.org/D71902. The last in a series of six patches that ports the LLVM coroutines