shafik added a comment.
Herald added a project: All.
It looks like the original bug no longer reproduces:
https://github.com/llvm/llvm-project/issues/42566
Is this PR still needed?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72103/new/
https://reviews.llvm.org/D72103
Mordante updated this revision to Diff 282460.
Mordante added a comment.
Rebased the patch and updated the unit tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72103/new/
https://reviews.llvm.org/D72103
Files:
clang/lib/Sema/SemaTemplate.cpp
Mordante added a comment.
Friendly ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72103/new/
https://reviews.llvm.org/D72103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Mordante added a comment.
Friendly ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72103/new/
https://reviews.llvm.org/D72103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61175 tests passed, 0 failed
and 729 were skipped.
{icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings
Mordante created this revision.
Mordante added reviewers: lvoufo, rsmith.
Mordante added a project: clang.
The function `Sema::CheckVarTemplateId` tries to find a template
specialization. If that fails it gets an `InsertPos` where the specialization
should be added in a `FoldingSet`. Then it
