[PATCH] D72221: Support function attribute patchable_function_entry

This revision was automatically updated to reflect the committed changes. Closed by commit rGa44c434b68e5: Support function attribute patchable_function_entry (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/

[PATCH] D72221: Support function attribute patchable_function_entry

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 ___ cfe-commits mailing list

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for all of the work that went into this. Looks like review comments have all been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61271 tests passed, 1 failed and 736 were skipped. failed: Clang.CodeGen/patchable-function-entry.c {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay updated this revision to Diff 236468. MaskRay marked 13 inline comments as done. MaskRay added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 Files:

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay added inline comments. Comment at: clang/include/clang/Basic/Attr.td:686 +def PatchableFunctionEntry : InheritableAttr { + let Spellings = [GCC<"patchable_function_entry">]; aaron.ballman wrote: > Should this be inheriting from `TargetSpecificAttr` as

[PATCH] D72221: Support function attribute patchable_function_entry

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:686 +def PatchableFunctionEntry : InheritableAttr { + let Spellings = [GCC<"patchable_function_entry">]; Should this be inheriting from `TargetSpecificAttr` as well given that

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:826 + "patchable-function-entry", + (Twine(Attr->getSize()) + "," + Twine(Attr->getStart())).str()); } ostannard wrote: > I think using two function

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4925 + T.getArch() != llvm::Triple::x86_64) { +S.Diag(getAttrLoc(AL), diag::err_attribute_unsupported) << AL; +return;

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4925 + T.getArch() != llvm::Triple::x86_64) { +S.Diag(getAttrLoc(AL), diag::err_attribute_unsupported) << AL; +return; Why is the target arch also checked in

[PATCH] D72221: Support function attribute patchable_function_entry

ostannard added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3995 +``__attribute__((patchable_function_entry(N,M)))`` is used to generate M NOPs +before the function entry and N-M NOPs after the function entry. This attributes +takes precedence over

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay updated this revision to Diff 236225. MaskRay added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 Files: clang/include/clang/Basic/Attr.td

[PATCH] D72221: Support function attribute patchable_function_entry

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61253 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay updated this revision to Diff 236221. MaskRay added a comment. Move a line from D7 to D72221 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay created this revision. MaskRay added reviewers: dberris, kristof.beyls, nickdesaulniers, rnk, rsmith, void. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added a parent revision: D72220: [X86] Support function attribute "patchable-function-entry". MaskRay