[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c044756e77: [clang-format] Add IndentCaseBlocks option (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D72276?vs=236740=238992#toc Repository: rG LLVM Github

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn added a comment. Ping. Please land on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn added a comment. Thanks for the review! I don't have committer access, feel free to land at your convenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

MyDeveloperDay added a comment. This LGTM, thanks for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276 ___ cfe-commits mailing list

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn updated this revision to Diff 236740. capn marked an inline comment as done. capn added a comment. Added case without {} to tests to ensure that still works as expected too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn updated this revision to Diff 236690. capn added a comment. Added release note update and test for both case labels and blocks being indented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276 Files:

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1235 + "}", + Style)); } MyDeveloperDay wrote: > Could you add a test with indented case labels and indented case blocks? what happens if

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

MyDeveloperDay added a comment. Could you add an entry into the clang-format section of the clang release notes Comment at: clang/unittests/Format/FormatTest.cpp:1235 + "}", + Style)); } Could you add a test with indented

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn created this revision. capn added a reviewer: clang-format. capn added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation for IndentCaseLabels claimed that the "Switch statement body is always indented one level more than case