[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

2020-01-08 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D72363#1810036 , @sfertile wrote: > LGTM: I really didn't like setting PIC as the default just to work around > some codegen bugs. I believe there are PowerPC codegen tests that will fail > with this change though (or perhaps

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

2020-01-08 Thread Sean Fertile via Phabricator via cfe-commits
sfertile added a comment. LGTM: I really didn't like setting PIC as the default just to work around some codegen bugs. I believe there are PowerPC codegen tests that will fail with this change though (or perhaps there is a PowerPC leak sanitizer build bot which begins to fail? @stefanp

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

2020-01-07 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG907a0cadb2c8: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72363/new/

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

2020-01-07 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61304 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

2020-01-07 Thread Brandon Bergren via Phabricator via cfe-commits
Bdragon28 added a comment. I am definitely in favor of this change, as the defaulting to PIC has been causing headaches in the FreeBSD kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72363/new/ https://reviews.llvm.org/D72363

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

2020-01-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: PowerPC, adalava, Bdragon28, sfertile, stefanp. Herald added subscribers: cfe-commits, steven.zhang, shchenz, jsji, kbarton, krytarowski, arichardson, nemanjai, emaste. Herald added a project: clang. According to D53384